[Editor] Make ink annotation editable

[calixteman]

No description provided.

[calixteman]

/botio test

[moz-tools-bot]

From: Bot.io (Linux m4)

---

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/ad5789582cadb54/output.txt

[moz-tools-bot]

From: Bot.io (Windows)

---

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/5cf09aae68508ca/output.txt

[moz-tools-bot]

From: Bot.io (Linux m4)

---

Failed

Full output at http://54.241.84.105:8877/ad5789582cadb54/output.txt

Total script time: 27.76 mins

• Unit tests: Passed
• Integration Tests: FAILED
• Regression tests: FAILED

  different ref/snapshot: 1

Image differences available at: http://54.241.84.105:8877/ad5789582cadb54/reftest-analyzer.html#web=eq.log

[moz-tools-bot]

From: Bot.io (Windows)

---

Failed

Full output at http://54.193.163.58:8877/5cf09aae68508ca/output.txt

Total script time: 48.78 mins

• Unit tests: Passed
• Integration Tests: FAILED
• Regression tests: Passed

[calixteman]

/botio integrationtest

[moz-tools-bot]

From: Bot.io (Linux m4)

---

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/a163cd6da0ee50b/output.txt

[moz-tools-bot]

From: Bot.io (Windows)

---

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/ee8c323ea51374b/output.txt

[moz-tools-bot]

From: Bot.io (Linux m4)

---

Success

Full output at http://54.241.84.105:8877/a163cd6da0ee50b/output.txt

Total script time: 9.11 mins

• Integration Tests: Passed

[moz-tools-bot]

From: Bot.io (Windows)

---

Success

Full output at http://54.193.163.58:8877/ee8c323ea51374b/output.txt

Total script time: 20.80 mins

• Integration Tests: Passed

[Snuffleupagus]

I've not done a full review, but leaving a couple of questions for now:

• Can the following code be removed now, thus re-enabling that integration-test?
  

  pdf.js/test/integration/annotation_spec.mjs

  Lines 507 to 514 in 97c7a8e

  	if (browserName) {
  	// TODO
  	pending(
  	"Re-enable this test when the Ink annotation has been made editable."
  	);
  	return;
  	}

• Should this PR be marked as fixes issue Support editing already existing ink-/stamp-annotations #16883, or is more work required?

[Snuffleupagus]

r=me, thank you.

[calixteman]

/botio makeref

[moz-tools-bot]

From: Bot.io (Windows)

---

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/b32557cf275a461/output.txt

[moz-tools-bot]

From: Bot.io (Linux m4)

---

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/b6014793c843be1/output.txt

[moz-tools-bot]

From: Bot.io (Linux m4)

---

Success

Full output at http://54.241.84.105:8877/b6014793c843be1/output.txt

Total script time: 17.36 mins

• Make references: Passed
• Check references: Passed

[moz-tools-bot]

From: Bot.io (Windows)

---

Success

Full output at http://54.193.163.58:8877/b32557cf275a461/output.txt

Total script time: 26.61 mins

• Make references: Passed
• Check references: Passed