Refactor the attachment code #5678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timvandermeij
force-pushed
the
pdf_attachment_view
branch
3 times, most recently
from
6ac8178 to
ed91df4
Compare
…tionality into methods
We can pass it in using the options object. Note that that this also avoids creating a DownloadManager object for each separate link (instead, having only one is enough).
timvandermeij
force-pushed
the
pdf_attachment_view
branch
from
ed91df4 to
b72395d
Compare
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/5e3867135d6db85/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/5e3867135d6db85/output.txt Total script time: 0.78 mins Published |
Snuffleupagus
added a commit
that referenced
this pull request
Jan 28, 2015
Refactor the attachment code
|
Great work, thank you! |
speedplane
pushed a commit
to speedplane/pdf.js
that referenced
this pull request
Feb 24, 2015
Refactor the attachment code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by #5673. This PR follows the same steps as that PR. A few test PDFs: