Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleaned whitespace #5693

Merged
merged 1 commit into from
Feb 28, 2015
Merged

cleaned whitespace #5693

merged 1 commit into from
Feb 28, 2015

Conversation

collinanderson
Copy link
Contributor

You can reproduce by running:

rm .git/index
git diff --binary -R HEAD | git apply --whitespace=fix --cached

@Snuffleupagus
Copy link
Collaborator

This looks good, but can you please revert the changes to the viewer.properties and chrome.properties files.
As explained in the fourth paragraph here, we're importing the translations from Firefox. Hence any whitespace changes made in those files will just be overwritten the next time we sync the l10n files.

@collinanderson
Copy link
Contributor Author

Done. Sorry for the delay.

@Snuffleupagus
Copy link
Collaborator

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux)

Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.21.233.14:8877/bdb60c9df8aaac8/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)

Success

Full output at http://107.21.233.14:8877/bdb60c9df8aaac8/output.txt

Total script time: 0.79 mins

Published

@Snuffleupagus
Copy link
Collaborator

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.21.233.14:8877/2692cf5e21661c6/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.22.172.223:8877/f6b35407c9ed551/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)

Success

Full output at http://107.22.172.223:8877/f6b35407c9ed551/output.txt

Total script time: 17.37 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Linux)

Success

Full output at http://107.21.233.14:8877/2692cf5e21661c6/output.txt

Total script time: 23.00 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@timvandermeij
Copy link
Contributor

@Snuffleupagus Is this good to go?

Snuffleupagus added a commit that referenced this pull request Feb 28, 2015
@Snuffleupagus
Merge pull request #5693 from collinanderson/whitespace
00ee6bd 
cleaned whitespace
@Snuffleupagus Snuffleupagus merged commit 00ee6bd into mozilla:master Feb 28, 2015
@Snuffleupagus
Copy link
Collaborator

Thank you for the patch!

speedplane pushed a commit to speedplane/pdf.js that referenced this pull request Mar 4, 2015
@Snuffleupagus
Merge pull request mozilla#5693 from collinanderson/whitespace
a801f12 
cleaned whitespace
@mozilla mozilla deleted a comment May 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
other
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@collinanderson @Snuffleupagus @pdfjsbot @timvandermeij