Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Firefox] Replace the CPOW with asynchronous messages for the Fallback bar #5918

Merged
merged 1 commit into from
Jul 7, 2015
Merged

[Firefox] Replace the CPOW with asynchronous messages for the Fallback bar #5918

merged 1 commit into from
Jul 7, 2015

Conversation

Snuffleupagus
Copy link
Collaborator

This patch removes the only remaining CPOW usage from the code-base, and should thus fix https://bugzilla.mozilla.org/show_bug.cgi?id=1071082.

Note: This will not fix the "Open With Different Viewer" button in e10s, since clicking it still fails with frontWindow is null in the console, but I do believe that that issue is somewhat orthogonal to this patch.

@Snuffleupagus
Copy link
Collaborator Author

This comment is somewhat unrelated to the PR.
When looking at the code, I'm not sure what the purpose of PdfjsContentUtils.displayWarning actually is. It seems to me that we could just as well send the PDFJS:Parent:displayWarning message directly from fallback in PdfStreamConverter.jsm, instead of calling a function to do it for us.

…k bar

This patch removes the only remaining CPOW usage from the code-base, and should thus fix https://bugzilla.mozilla.org/show_bug.cgi?id=1071082.

*Note:* This will not fix the "Open With Different Viewer" button in e10s, since clicking it still fails with `frontWindow is null` in the console, but I do believe that that issue is somewhat orthogonal to the current patch.
@Snuffleupagus
Copy link
Collaborator Author

The second commit was removed, since that code change is included in PR #5966 instead.

/botio-windows preview

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.22.172.223:8877/82ae88dad5b8188/output.txt

@timvandermeij
Copy link
Contributor

@yurydelendik What is the status of this? Probably the e10s people would like to have this landed.

yurydelendik added a commit that referenced this pull request Jul 7, 2015
[Firefox] Replace the CPOW with asynchronous messages for the Fallback bar
@yurydelendik yurydelendik merged commit eb2ad11 into mozilla:master Jul 7, 2015
@yurydelendik
Copy link
Contributor

Thank you for the patch

@Snuffleupagus Snuffleupagus deleted the remove-fallback-cpow branch July 7, 2015 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants