Make sure that the document is rendered on zooming and rotation for PDFViewer instances using the defaultRenderingQueue
#6157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…PDFViewer` instances using the `defaultRenderingQueue` In `viewer.js` we have code that ensures that the document is re-rendered on zooming and rotation. However, for `components` based viewers this might not work correctly, since there's currently no code which handles that. Note that there is a good chance that this "just works" in many `components` viewers already, thanks to the `watchScroll` function. The explanation is that zooming or rotation, most of the time, causes the viewer to change its (scrollable) size, thus triggering `PDFViewer_update` through `PDFViewer_scrollUpdate`. However, in general there's no guarantee that this will actually work (since zooming and rotation doesn't necessarily change the size of the viewer for all documents), and requiring every viewer `components` implementer to provide methods for this doesn't seem like a great idea.
|
@timvandermeij Would you be up for reviewing this patch?
|
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/32f9b6f16511bd4/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/32f9b6f16511bd4/output.txt Total script time: 0.65 mins Published |
timvandermeij
added a commit
that referenced
this pull request
Jul 16, 2015
…cale-and-pagesRotation Make sure that the document is rendered on zooming and rotation for `PDFViewer` instances using the `defaultRenderingQueue`
|
Looks good, thank you for the patch and for providing the clear testing steps! |
Snuffleupagus
deleted the
components-update-on-setScale-and-pagesRotation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
viewer.jswe have code that ensures that the document is re-rendered on zooming and rotation. However, forcomponentsbased viewers this might not work correctly, since there's currently no code which handles that.Note that there is a good chance that this "just works" in many
componentsviewers already, thanks to thewatchScrollfunction.The explanation is that zooming or rotation, most of the time, causes the viewer to change its (scrollable) size, thus triggering
PDFViewer_updatethroughPDFViewer_scrollUpdate.However, in general there's no guarantee that this will actually work (since zooming and rotation doesn't necessarily change the size of the viewer for all documents), and requiring every viewer
componentsimplementer to provide methods for this doesn't seem like a great idea.