More cleanup regarding annotation border styles #6215
Conversation
| var dict = new Dict(); | ||
| dict.name = 'D'; | ||
| borderStyle.setStyle(dict); | ||
| borderStyle.setStyle({ name: 'D' }); |
There was a problem hiding this comment.
Isn't a Name actually what you want to use here, since that is what dict.get('S') (in annotation.js) will return?
If so, using borderStyle.setStyle(Name.get('D')); here should be slightly more clear.
There was a problem hiding this comment.
Done in the new commit.
|
Good to merge, once the comment is addressed. |
timvandermeij
force-pushed
the
annotation-border-fixes
branch
2 times, most recently
from
58876ad to
bed4d67
Compare
timvandermeij
force-pushed
the
annotation-border-fixes
branch
from
bed4d67 to
465611a
Compare
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/a775534359e4732/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/a775534359e4732/output.txt Total script time: 0.63 mins Published |
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.22.172.223:8877/b42b95122f9b283/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/d273f2bcbf179f4/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/d273f2bcbf179f4/output.txt Total script time: 19.36 mins
|
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/b42b95122f9b283/output.txt Total script time: 20.04 mins
|
More cleanup regarding annotation border styles
|
Looks good, thanks! |
This PR provides (minor) clean-up for the annotation border styles. There are three changes:
this.borderStyle.setStyle('S');is wrong assetStyletakes aNameas parameter, not a string. Somehow we all missed this during review, but fortunately we do not even need that line because the solid border style is the default.drawBorderparameter forinitContainerhas become unused after the annotation border style refactoring, so we can remove it.setStyletakes aNameas parameter, not a dictionary (even though that worked too, it is better to keep it the same as what we expect).@Snuffleupagus Could you review this one too?