Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply hover style to .overlayButton not only when hovered, but also when focused. #6308

Merged
merged 1 commit into from
Aug 4, 2015
Merged

Conversation

dsprenkels
Copy link
Contributor

This commit fixes #6261 by taking the focus style of this button to be the same as the hover style.

@Snuffleupagus
Copy link
Collaborator

@dsprenkels Please update the commit message to something more descriptive than just fix for #6261; ideally the commit message should briefly describe what the patch actually does.

@dsprenkels dsprenkels changed the title fix for #6261 Apply hover style to .overlayButton not only when hovered, but also when focused. Aug 4, 2015
@dsprenkels
Copy link
Contributor Author

I hope this description suits this pull request well enough. 😐

@CodingFabian
Copy link
Contributor

great! But the title of the PR is mostly hidden once the commit is merged. can you update the title of the commit as well? Amend it and then force push.

@timvandermeij
Copy link
Contributor

/botio-linux preview

@pdfjsbot
Copy link

pdfjsbot commented Aug 4, 2015

From: Bot.io (Linux)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/9829877721b4319/output.txt

timvandermeij added a commit that referenced this pull request Aug 4, 2015
Apply hover style to .overlayButton not only when hovered, but also when focused.
@timvandermeij timvandermeij merged commit 1f94d84 into mozilla:master Aug 4, 2015
@timvandermeij
Copy link
Contributor

Thank you!

@dsprenkels dsprenkels deleted the issue_6261 branch August 4, 2015 21:45
@dsprenkels
Copy link
Contributor Author

Thank you for merging! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No visual indicator when a Document Properties close button is focused
5 participants