Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slightly improved test coverage for vertical text #6399

Merged
merged 1 commit into from
Aug 31, 2015
Merged

Slightly improved test coverage for vertical text #6399

merged 1 commit into from
Aug 31, 2015

Conversation

Snuffleupagus
Copy link
Collaborator

Our current test coverage for vertical text is somewhat lacking, as evident from e.g. issue #6387. That regression could easily have been avoided if the taro test-case would have been an eq test, as well as an text test.

Our current test coverage for vertical text is somewhat lacking, as evident from e.g. issue 6387. That regression could easily have been avoided if the `taro` test-case would have been an `eq` test, as well as an `text` test.
@Snuffleupagus
Copy link
Collaborator Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.22.172.223:8877/941b37febdf078c/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.21.233.14:8877/769358cdc36e3f6/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/941b37febdf078c/output.txt

Total script time: 18.93 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/769358cdc36e3f6/output.txt

Total script time: 19.28 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@timvandermeij
Copy link
Contributor

/botio makeref

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_makeref from @timvandermeij received. Current queue size: 0

Live output at: http://107.22.172.223:8877/7cf1fffabf5f572/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_makeref from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/dc81d979dff0f7c/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/7cf1fffabf5f572/output.txt

Total script time: 18.07 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/dc81d979dff0f7c/output.txt

Total script time: 19.31 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

timvandermeij added a commit that referenced this pull request Aug 31, 2015
Slightly improved test coverage for vertical text
@timvandermeij timvandermeij merged commit 678b662 into mozilla:master Aug 31, 2015
@timvandermeij
Copy link
Contributor

Thank you for your work on the tests!

@Snuffleupagus Snuffleupagus deleted the vertical-text-taro branch August 31, 2015 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants