Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set TZ=UTC before calls to zip #6402

Merged
merged 1 commit into from
Aug 31, 2015

Conversation

DavidPrevot
Copy link

This change allows to make the package build reproducible.

While working on the "reproducible builds" effort 1, we have noticed
that pdf.js could not be built reproducibly.

The attached patch removes timezone-varying timestamps from the
files compressed with zip. Once applied, pdf.js can be built
reproducibly in our current experimental framework.

Bug-Debian: https://bugs.debian.org/793127

This change allows to make the package build reproducible.

Bug-Debian: https://bugs.debian.org/793127
@timvandermeij
Copy link
Contributor

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/1c545901c65d2ed/output.txt

timvandermeij added a commit that referenced this pull request Aug 31, 2015
@timvandermeij timvandermeij merged commit 8f1b065 into mozilla:master Aug 31, 2015
@timvandermeij
Copy link
Contributor

Good, thanks!

@Snuffleupagus
Copy link
Collaborator

There are other callers of zip in make.js, see https://github.com/mozilla/pdf.js/blob/master/make.js#L377, so shouldn't this have been set globally instead of just in one place!?

@timvandermeij
Copy link
Contributor

I think this change is only useful for the XPI builds. node make publish is, as far as I can tell, and correct me if I'm wrong, only used by us to only once create the release package. We could make this change global for the sake of consistency (feel free to create a follow-up patch for that), although for the Debian people (and for how I understand the make commands) this patch should also be enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants