Prevent TypeError: page is undefined when the document has been destroyed (PR 6546 follow-up)
#6560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's probably better to have approach, when we check for state rather than presence in the cache, e.g. via |
…troyed (PR 6546 follow-up) *Follow-up to PR 6546.* If rendering has already started when the document is destroyed, then `this.pageCache[data.pageIndex]` may already have been cleared when the `StartRenderingPage`/`RenderPageChunk` messages are recieved in `api.js`, which results in `TypeError`s being thrown.
Sure; I've pushed an updated version of the patch. |
|
/botio-linux test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://107.21.233.14:8877/069462ab9318211/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/069462ab9318211/output.txt Total script time: 19.62 mins
|
yurydelendik
added a commit
that referenced
this pull request
Oct 23, 2015
…r_page_is_undefined Prevent `TypeError: page is undefined` when the document has been destroyed (PR 6546 follow-up)
|
Thank you for the patch. |
Snuffleupagus
deleted the
pr-6546-followup-TypeError_page_is_undefined
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to PR #6546.
If rendering has already started when the document is destroyed, then
this.pageCache[data.pageIndex]may already have been cleared when theStartRenderingPage/RenderPageChunkmessages are recieved inapi.js, which results inTypeErrors being thrown.r? @yurydelendik