Dispatch the pagerendered event when zooming is only done with CSS (issue 6463)
#6625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…(issue 6463) In my opinion, this event shouldn't be dispatched in `PDFPageView.cssTransform`, since that would cause *two* events to be fired when "normal" zooming is used (once in `PDFPageView.cssTransform`, and once in `PDFPageView.draw`). Fixes 6463.
|
/botio-windows preview |
From: Bot.io (Windows)ReceivedCommand cmd_preview from @yurydelendik received. Current queue size: 0 Live output at: http://107.22.172.223:8877/cb790ba1560da88/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/cb790ba1560da88/output.txt Total script time: 1.33 mins Published |
yurydelendik
added a commit
that referenced
this pull request
Nov 12, 2015
Dispatch the `pagerendered` event when zooming is only done with CSS (issue 6463)
|
Thank you for the patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my opinion, this event shouldn't be dispatched in
PDFPageView.cssTransform, since that would cause two events to be fired when "normal" zooming is used (once inPDFPageView.cssTransform, and once inPDFPageView.draw).Fixes #6463.