Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove glyph id's outside the range of valid glyphs. #6715

Merged
merged 1 commit into from
Dec 3, 2015

Conversation

brendandahl
Copy link
Contributor

OTS does not like invalid glyph ids in a camp table.
Fixes issues with warning "Range glyph reference too high"

Fixes #5564, #6648, #3483, #5702, #6343, #5690. Maybe more, we should look for people talking about boxes appearing.

@Snuffleupagus
Copy link
Collaborator

/botio-linux preview

@pdfjsbot
Copy link

pdfjsbot commented Dec 3, 2015

From: Bot.io (Linux)


Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://107.21.233.14:8877/89faa021f195db2/output.txt

@Snuffleupagus
Copy link
Collaborator

Really nice patch!

r=me, provided that the tests pass, and with the PDF file added to .gitignore.

Edit: Also fixes #5514.

@timvandermeij
Copy link
Contributor

Nice indeed! It also fixes #6312.

@yurydelendik
Copy link
Contributor

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Dec 3, 2015

From: Bot.io (Windows)


Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.22.172.223:8877/aa1598c4b349dcf/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Dec 3, 2015

From: Bot.io (Linux)


Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.21.233.14:8877/3a4df09046f5483/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Dec 3, 2015

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/aa1598c4b349dcf/output.txt

Total script time: 19.49 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

pdfjsbot commented Dec 3, 2015

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/3a4df09046f5483/output.txt

Total script time: 19.75 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

OTS does not like invalid glyph ids in a camp table.
timvandermeij added a commit that referenced this pull request Dec 3, 2015
Remove glyph id's outside the range of valid glyphs.
@timvandermeij timvandermeij merged commit e180d01 into mozilla:master Dec 3, 2015
@timvandermeij
Copy link
Contributor

Awesome work, thank you!

@timvandermeij
Copy link
Contributor

/botio makeref

@pdfjsbot
Copy link

pdfjsbot commented Dec 3, 2015

From: Bot.io (Windows)


Received

Command cmd_makeref from @timvandermeij received. Current queue size: 2

Live output at: http://107.22.172.223:8877/c932f65147afed9/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Dec 3, 2015

From: Bot.io (Linux)


Received

Command cmd_makeref from @timvandermeij received. Current queue size: 2

Live output at: http://107.21.233.14:8877/1ad4f95d8dbf9d6/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Dec 3, 2015

From: Bot.io (Windows)


Success

Full output at http://107.22.172.223:8877/c932f65147afed9/output.txt

Total script time: 19.04 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

pdfjsbot commented Dec 3, 2015

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/1ad4f95d8dbf9d6/output.txt

Total script time: 19.84 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants