-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement annotation layer regression testing #6780
Implement annotation layer regression testing #6780
Conversation
page); | ||
}); | ||
} else { | ||
initPromise = Promise.resolve(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make annotationLayerCanvas = null
; here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in the new commit.
7dee3c7
to
8a8e9b2
Compare
8aeeb07
to
a4e1128
Compare
|
||
var annotation_viewport = viewport.clone({ dontFlip: true }); | ||
PDFJS.AnnotationLayer.render(annotation_viewport, div, annotations, | ||
page, new LinkServiceMock()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a reminder: With PR #6770 landed, the parameters now need to be passed in as an object instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in the new commit.
a4e1128
to
b7217a2
Compare
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.22.172.223:8877/dc3151ec85901e3/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/ca99b9e771221f2/output.txt |
From: Bot.io (Windows)FailedFull output at http://107.22.172.223:8877/dc3151ec85901e3/output.txt Total script time: 20.42 mins
Image differences available at: http://107.22.172.223:8877/dc3151ec85901e3/reftest-analyzer.html#web=eq.log |
From: Bot.io (Linux)FailedFull output at http://107.21.233.14:8877/ca99b9e771221f2/output.txt Total script time: 20.60 mins
Image differences available at: http://107.21.233.14:8877/ca99b9e771221f2/reftest-analyzer.html#web=eq.log |
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://107.21.233.14:8877/4915539bf39bf86/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://107.22.172.223:8877/aab2683bb27f925/output.txt |
From: Bot.io (Windows)FailedFull output at http://107.22.172.223:8877/aab2683bb27f925/output.txt Total script time: 20.38 mins
Image differences available at: http://107.22.172.223:8877/aab2683bb27f925/reftest-analyzer.html#web=eq.log |
From: Bot.io (Linux)FailedFull output at http://107.21.233.14:8877/4915539bf39bf86/output.txt Total script time: 20.64 mins
Image differences available at: http://107.21.233.14:8877/4915539bf39bf86/reftest-analyzer.html#web=eq.log |
Looks good. Thank you for the patch. /botio makeref |
From: Bot.io (Linux)ReceivedCommand cmd_makeref from @yurydelendik received. Current queue size: 0 Live output at: http://107.21.233.14:8877/0100a7fcb9a0f9e/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @yurydelendik received. Current queue size: 0 Live output at: http://107.22.172.223:8877/4536234cc4c2591/output.txt |
Implement annotation layer regression testing
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/0100a7fcb9a0f9e/output.txt Total script time: 20.25 mins
|
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/4536234cc4c2591/output.txt Total script time: 20.41 mins
|
Fixes #6673.