Remove PDFThumbnailViewer_ensureThumbnailVisible
#7040
Merged
+8
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Functionality wise, `ensureThumbnailVisible` is essentially just a shorthand for `scrollThumbnailIntoView`. (And note that `PDFViewer` doesn't implement a `ensurePageVisible` method.) The only remaining usage of `PDFThumbnailViewer_ensureThumbnailVisible` is inside `PDFPresentationMode`, which introduces an otherwise unnecessary `PDFThumbnailViewer` dependency there. We're already relying on the `presentationmodechanged` event, in various files, to track the state of Presentation Mode. Thus we can simply listen for that event in `PDFSidebar` too, and update the thumbnails if necessary.
|
/botio-windows preview |
From: Bot.io (Windows)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/453cdcd3bde48d6/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/453cdcd3bde48d6/output.txt Total script time: 1.26 mins Published |
timvandermeij
added a commit
that referenced
this pull request
Feb 28, 2016
…_ensureThumbnailVisible Remove `PDFThumbnailViewer_ensureThumbnailVisible`
|
Looks good, thank you! |
Snuffleupagus
deleted the
remove-PDFThumbnailViewer_ensureThumbnailVisible
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functionality wise,
ensureThumbnailVisibleis essentially just a shorthand forscrollThumbnailIntoView. (And note thatPDFViewerdoesn't implement aensurePageVisiblemethod.)The only remaining usage of
PDFThumbnailViewer_ensureThumbnailVisibleis insidePDFPresentationMode, which introduces an otherwise unnecessaryPDFThumbnailViewerdependency there.We're already relying on the
presentationmodechangedevent, in various files, to track the state of Presentation Mode. Thus we can simply listen for that event inPDFSidebartoo, and update the thumbnails if necessary.