-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid accidentally getting the entire font file in readNameTable
(issue 7020)
#7049
Conversation
…ssue 7020) In the PDF file in question, some of the 'name' table entries have `record.length === 0`. This becomes problematic in the non-unicode case, since `font.getBytes(0)` will fetch the *entire* stream. Given that OTS rejects 'name' entries larger than `2^16`, this thus explain the sanitizer errors. Fixes 7020.
/botio-windows preview |
From: Bot.io (Windows)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/57cd1dc13651dd8/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/57cd1dc13651dd8/output.txt Total script time: 1.35 mins Published |
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/8db2d05f6e5679b/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/674c00fbb153693/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/674c00fbb153693/output.txt Total script time: 20.35 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/8db2d05f6e5679b/output.txt Total script time: 22.18 mins
|
/botio makeref |
From: Bot.io (Linux)ReceivedCommand cmd_makeref from @brendandahl received. Current queue size: 1 Live output at: http://107.21.233.14:8877/06f77a103310b7e/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @brendandahl received. Current queue size: 1 Live output at: http://107.22.172.223:8877/98d735ea2736270/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/98d735ea2736270/output.txt Total script time: 19.87 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/06f77a103310b7e/output.txt Total script time: 21.32 mins
|
Avoid accidentally getting the entire font file in `readNameTable` (issue 7020)
Nice! |
In the PDF file in question, some of the 'name' table entries have
record.length === 0
. This becomes problematic in the non-unicode case, sincefont.getBytes(0)
will fetch the entire stream.Given that OTS rejects 'name' entries larger than
2^16
, this thus explain the sanitizer errors.Fixes #7020.