Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introducing gulp #7061

Merged
merged 1 commit into from
Mar 4, 2016
Merged

Introducing gulp #7061

merged 1 commit into from
Mar 4, 2016

Conversation

yurydelendik
Copy link
Contributor

... along with make.js.

@timvandermeij
Copy link
Contributor

Gulp needs to be installed globally for gulp to work in the terminal and from make.js. Therefore I suggest to add npm install -g gulpnpm install -g gulp-cli after npm install in README.md so that this is clear.

timvandermeij
timvandermeij reviewed Mar 4, 2016
View reviewed changes
gulpfile.js
});

gulp.task('makefile', function () {
var makefileContent = 'help:\n\gulp\n\n';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\gulp must be \tgulp, otherwise running gulp makefile and then make server throws Makefile:2: *** missing separator.

@yurydelendik yurydelendik force-pushed the gulp branch 5 times, most recently from 0cf6ebe to 857a914 Compare March 4, 2016 15:35
@timvandermeij timvandermeij self-assigned this Mar 4, 2016
@timvandermeij
Copy link
Contributor

/botio lint

@pdfjsbot
Copy link

pdfjsbot commented Mar 4, 2016

From: Bot.io (Windows)

Received

Command cmd_lint from @timvandermeij received. Current queue size: 0

Live output at: http://107.22.172.223:8877/183d0cf7aafe012/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Mar 4, 2016

From: Bot.io (Linux)

Received

Command cmd_lint from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/e03ef5fb8e9d386/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Mar 4, 2016

From: Bot.io (Linux)

Success

Full output at http://107.21.233.14:8877/e03ef5fb8e9d386/output.txt

Total script time: 1.08 mins

  • Lint: Passed

@pdfjsbot
Copy link

pdfjsbot commented Mar 4, 2016

From: Bot.io (Windows)

Success

Full output at http://107.22.172.223:8877/183d0cf7aafe012/output.txt

Total script time: 1.88 mins

  • Lint: Passed

@timvandermeij
Copy link
Contributor

/botio-linux preview

@pdfjsbot
Copy link

pdfjsbot commented Mar 4, 2016

From: Bot.io (Linux)

Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://107.21.233.14:8877/3a87a093202567e/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Mar 4, 2016

From: Bot.io (Linux)

Success

Full output at http://107.21.233.14:8877/3a87a093202567e/output.txt

Total script time: 0.95 mins

Published

timvandermeij added a commit that referenced this pull request Mar 4, 2016
@timvandermeij
Merge pull request #7061 from yurydelendik/gulp
ec1cf28 
Introducing gulp
@timvandermeij timvandermeij merged commit ec1cf28 into mozilla:master Mar 4, 2016
@timvandermeij
Copy link
Contributor

Thanks!

@fkaelberer
Copy link
Contributor

Gulp needs to be installed globally for gulp to work in the terminal and from make.js. Therefore I suggest to add npm install -g gulp after npm install in README.md so that this is clear.

@timvandermeij This should also be updated in the Contributing wiki site.

@yurydelendik
Copy link
Contributor Author

npm install -g gulp

It shall be npm install -g gulp-cli

@yurydelendik
Copy link
Contributor Author

This should also be updated in the Contributing wiki site.

Added in prereq section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@timvandermeij timvandermeij

Labels
other
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yurydelendik @timvandermeij @pdfjsbot @fkaelberer