Refactor the building of toFontChar for non-embedded fonts
#7078
Conversation
Currently there's a lot of duplicate code for non-embedded `toFontChar`, which this patch simplifies by extracting the code into a helper function instead.
|
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/eb54cbe76d37a34/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.22.172.223:8877/b45f74ab049e02b/output.txt |
From: Bot.io (Linux)FailedFull output at http://107.21.233.14:8877/eb54cbe76d37a34/output.txt Total script time: 15.13 mins
Image differences available at: http://107.21.233.14:8877/eb54cbe76d37a34/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/b45f74ab049e02b/output.txt Total script time: 20.48 mins
|
|
/botio-linux test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/9ffaf371dbf7aee/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/9ffaf371dbf7aee/output.txt Total script time: 22.87 mins
|
|
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @brendandahl received. Current queue size: 0 Live output at: http://107.21.233.14:8877/7fb8493c3d240dd/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @brendandahl received. Current queue size: 1 Live output at: http://107.22.172.223:8877/676dc1543d878e3/output.txt |
|
r+ pending passing tests |
|
And nice code removal! |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/676dc1543d878e3/output.txt Total script time: 20.18 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/7fb8493c3d240dd/output.txt Total script time: 21.84 mins
|
Currently there's a lot of duplicate code for non-embedded
toFontChar, which this patch simplifies by extracting the code into a helper function instead.