-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed partial print issue on IE / Edge #7499
Conversation
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://107.21.233.14:8877/28fdb624aa3247a/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/28fdb624aa3247a/output.txt Total script time: 1.06 mins Published |
Any status on this PR? Please let me know if any changes are requested to move this forward. |
The commit itself looks good to me. We mainly need to do more manual testing before merging this. |
CustomStyle.setProp('transformOrigin' , canvas, '0% 0%'); | ||
|
||
var canvasWrapper = document.createElement('div'); | ||
canvasWrapper.style.width = '100%'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this actually necessary, given that it should already be set with CSS, see
Line 1813 in 336b26a
height: 100%; |
Generally I agree, but I've added a couple of questions/comments above.
Agreed; and this is sort of time-consuming to do. We'd need to ensure that this isn't regressing other printing fixes, e.g. PR #7005. |
…artial-print-issue
The DPI shall be set now to 150%. See #7677. Thanks. |
Fixed partial print issue for IE / Edge as described in issue #3983.
Issue Description
When printing a PDF from the PDF.js viewer, pages are being cutoff near the bottom of the page.
Steps to reproduce
Fix Description
The issue was fixed by changing the rendered size of the canvas to 100%, setting the CSS scale factor to 1 for both the width and height, changing the PRINT_OUTPUT_SCALE to be dependent on DPI, and fixing the PT to PX conversion between the viewport and canvas measurements.
Notes
All tests pass.
Confirmed that the issue has been fixed on IE 11.494, Edge 25.1, FF 47.0.1, Chrome 51.0
The PRINT_OUTPUT_SCALE factor has not been changed.