Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publishes processed sources into pdfjs-dist/lib #8120

Merged
merged 2 commits into from
Mar 4, 2017

Conversation

yurydelendik
Copy link
Contributor

We need to publish cjs modules (e.g. to run unittestcli or just for node.js). We are going to move to ES6 syntax soon. So that will help with using modules outside of the main repo.

@yurydelendik
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Mar 1, 2017

From: Bot.io (Linux)


Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://107.21.233.14:8877/6dcb91aac6f615e/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Mar 1, 2017

From: Bot.io (Windows)


Received

Command cmd_test from @yurydelendik received. Current queue size: 0

Live output at: http://54.215.176.217:8877/65ae14556bd397e/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Mar 1, 2017

From: Bot.io (Windows)


Success

Full output at http://54.215.176.217:8877/65ae14556bd397e/output.txt

Total script time: 23.50 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

@pdfjsbot
Copy link

pdfjsbot commented Mar 1, 2017

From: Bot.io (Linux)


Success

Full output at http://107.21.233.14:8877/6dcb91aac6f615e/output.txt

Total script time: 29.45 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Regression tests: Passed

Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me, with one (optional) comment.

gulpfile.js Outdated

return merge([
gulp.src([
'src/{core,display,shared}/*.js',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I don't feel strongly about it, however you may wish to skip src/shared/cffStandardStrings.js and src/shared/fonts_utils.js here, since neither of those are used in production currently (or anywhere else for that matter).

@yurydelendik yurydelendik merged commit c290561 into mozilla:master Mar 4, 2017
@yurydelendik yurydelendik deleted the lib branch March 4, 2017 14:48
movsb pushed a commit to movsb/pdf.js that referenced this pull request Jul 14, 2018
Publishes processed sources into pdfjs-dist/lib
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants