-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publishes processed sources into pdfjs-dist/lib #8120
Conversation
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://107.21.233.14:8877/6dcb91aac6f615e/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://54.215.176.217:8877/65ae14556bd397e/output.txt |
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/65ae14556bd397e/output.txt Total script time: 23.50 mins
|
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/6dcb91aac6f615e/output.txt Total script time: 29.45 mins
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine to me, with one (optional) comment.
gulpfile.js
Outdated
|
||
return merge([ | ||
gulp.src([ | ||
'src/{core,display,shared}/*.js', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: I don't feel strongly about it, however you may wish to skip src/shared/cffStandardStrings.js and src/shared/fonts_utils.js here, since neither of those are used in production currently (or anywhere else for that matter).
Publishes processed sources into pdfjs-dist/lib
We need to publish cjs modules (e.g. to run unittestcli or just for node.js). We are going to move to ES6 syntax soon. So that will help with using modules outside of the main repo.