Refactor removing of the zoomLayer into a helper method, and use that in PDFPageView.reset to ensure that the entire zoomLayer is actually removed (issue 8209)
#8210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at in `PDFPageView.reset` to ensure that the entire `zoomLayer` is actually removed (issue 8209)
|
/botio-linux preview |
From: Bot.io (Linux)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://107.21.233.14:8877/b29e34824efa5ca/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/b29e34824efa5ca/output.txt Total script time: 2.72 mins Published |
timvandermeij
approved these changes
Mar 30, 2017
|
Thank you for the fix! |
movsb
pushed a commit
to movsb/pdf.js
that referenced
this pull request
Jul 14, 2018
Refactor removing of the `zoomLayer` into a helper method, and use that in `PDFPageView.reset` to ensure that the entire `zoomLayer` is actually removed (issue 8209)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8209.
Slightly easier reviewing with https://github.com/mozilla/pdf.js/pull/8210/files?w=1.
A note for the reviewer: Given that the issue can be intermittent, since it depends on the
renderingStateof the page(s) whencleanupis triggered, reproducing the issue and then verifying the patch can take a couple of tries (at least it did for me).In order to speed up this process, my recommendation is to test locally both with and without the patch, with the
CLEANUP_TIMEOUTset to e.g.300(or similar) since that makes the problem occur much quicker.