Restore the URL.createObjectURL check to the createObjectURL utility function (issue 8344)
#8346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ity function (issue 8344) This is a regression from commit 3888a99. It turns out the even though we have a `URL` polyfill, it's still dependent on the existence of native `URL.{createObjectURL, revokeObjectURL}` functions. Since no such thing exists in Node.js, our `createObjectURL` utility function breaks there.
|
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://107.21.233.14:8877/1de3dabe874936b/output.txt |
|
/botio-windows test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @yurydelendik received. Current queue size: 0 Live output at: http://54.215.176.217:8877/bacb632dd3cdb02/output.txt |
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/bacb632dd3cdb02/output.txt Total script time: 24.03 mins
Image differences available at: http://54.215.176.217:8877/bacb632dd3cdb02/reftest-analyzer.html#web=eq.log |
From: Bot.io (Linux)FailedFull output at http://107.21.233.14:8877/1de3dabe874936b/output.txt Total script time: 33.91 mins
Image differences available at: http://107.21.233.14:8877/1de3dabe874936b/reftest-analyzer.html#web=eq.log |
|
Thank you for the patch. |
movsb
pushed a commit
to movsb/pdf.js
that referenced
this pull request
Jul 14, 2018
Restore the `URL.createObjectURL` check to the `createObjectURL` utility function (issue 8344)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a regression from commit 3888a99.
It turns out the even though we have a
URLpolyfill, it's still dependent on the existence of nativeURL.{createObjectURL, revokeObjectURL}functions.Since no such thing exists in Node.js, our
createObjectURLutility function breaks there.Fixes #8344.