-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Combine the common styles and overrides for the annotation layer reference tests #8893
Combine the common styles and overrides for the annotation layer reference tests #8893
Conversation
reference tests This patch allows us to use the common styles as used by the viewer as a baseline for the annotation layer reference tests. They are extended with a small set of overrides to ensure that all elements are visible during the test. The overrides file now only contains the absolutely necessary rules to make all elements visible and is therefore no longer an almost verbatim copy of the common styles.
ed3ca4d
to
23cbe29
Compare
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/b049a27e4ab6a01/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/b049a27e4ab6a01/output.txt Total script time: 2.28 mins Published |
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/9dac8f127d21edf/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.215.176.217:8877/815ea3f8dee02a2/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/9dac8f127d21edf/output.txt Total script time: 16.63 mins
|
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/815ea3f8dee02a2/output.txt Total script time: 29.68 mins
Image differences available at: http://54.215.176.217:8877/815ea3f8dee02a2/reftest-analyzer.html#web=eq.log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Too bad that we don't load the stylesheets in a way that supports @import
, but still much nicer than having to maintain two copies of the same CSS rules :-)
Looks good, thank you!
Combine the common styles and overrides for the annotation layer reference tests
This patch allows us to use the common styles as used by the viewer as a baseline for the annotation layer reference tests. They are extended with a small set of overrides to ensure that all elements are visible during the test.
The overrides file now only contains the absolutely necessary rules to make all elements visible and is therefore no longer an almost verbatim copy of the common styles.
@Snuffleupagus Since you came up with this nice suggestion, would you be willing to review this?