Improve error message when Firefox binary path is misconfigured.

mozilla · Jul 24, 2018 · 5e80640 · 5e80640
1 parent 6519787
commit 5e80640
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/bin/run_tests.py b/bin/run_tests.py
@@ -31,6 +31,13 @@
     help='Path to Firefox binary',
 )
 def main(firefox_bin):
+    if not firefox_bin:
+        raise click.BadParameter(
+            'No Firefox binary found; configure the path to Firefox with `npm config`.'
+        )
+    elif not os.path.exists(firefox_bin):
+        raise click.BadParameter('Path to Firefox binary does not exist.')
+
     click.echo('== Building test bundle with Webpack')
     bundle_handle, bundle_path = mkstemp()
     try: