This repository has been archived by the owner on Dec 3, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 15
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
#36: Add more sophisticated Fathom rules.
These rules successfully pull out product title, price and image from the following product pages (one each from the 5 top sites): * [Amazon](https://www.amazon.com/KitchenAid-KL26M1XER-Professional-6-Qt-Bowl-Lift/dp/B01LYV1U30?smid=ATVPDKIKX0DER&pf_rd_p=0c7b792f-241a-4510-94f4-dd184a76f201&pf_rd_r=AZD7BGV3JZGTB23F30X3) * [Ebay](https://www.ebay.com/p/Best-Choice-Products-650W-6-speed-5-5QT-Kitchen-Food-Stand-Mixer-with-Stainless-Steels-Bowl-Black/3018375728?iid=253733404998) * [Walmart](https://www.walmart.com/ip/KitchenAid-Classic-Series-4-5-Quart-Tilt-Head-Stand-Mixer-Onyx-Black-K45SSOB/29474640) * [Best Buy](https://www.bestbuy.com/site/jbl-everest-elite-750nc-wireless-over-ear-noise-cancelling-headphones-gunmetal/5840136.p?skuId=5840136) * [Home Depot](https://www.homedepot.com/p/Husky-SAE-Combination-Wrench-Set-10-Piece-HCW10PCSAE/202934501) TODO: * Create a training set with FathomFox and run these rules against them to measure their accuracy for 50 product pages (10 from each top site). * Modify trimTitle method, so it doesn't cut off the color from the title for the product on Ebay. * Generalize formatPrice method. @Osmose, would you have any suggestions?
- Loading branch information
1 parent
6391a7d
commit 934cc71
Showing
2 changed files
with
149 additions
and
26 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,5 @@ | ||
{ | ||
"hasPriceClass": 2 | ||
"largerImage": 3, | ||
"largerFontSize": 2, | ||
"hasDollarSign": 3 | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's too ambiguous to assume that the last two numbers are cents. Looking at their HTML, our best bet is to do some extra matching on the dom nodes within "priceish" matches to find
unit
andsubunit
nodes. We could maybe leverage Fathom to do this further matching, maybe with a second ruleset applied to the winningpriceish
node?Then we could match unit and subunit on things like:
For now I'd ignore handling this properly and defer Home Depot working to another PR.