Merge pull request #275 from erikrose/90%-price

92% price accuracy

package.json

@@ -51,7 +51,7 @@
   "dependencies": {
     "autobind-decorator": "2.1.0",
     "dinero.js": "1.4.0",
-    "fathom-web": "2.3.0",
+    "fathom-web": "2.8.0",
     "lodash.maxby": "4.6.0",
     "lodash.minby": "4.6.0",
     "lodash.orderby": "^4.6.0",

src/extraction/fathom/coefficients.json

@@ -1,12 +1,16 @@
 {
-  "hasDollarSignCoeff": 8,
-  "hasPriceInClassNameCoeff": 2,
-  "hasPriceInIDCoeff": 17,
-  "hasPriceishPatternCoeff": 15,
-  "isAboveTheFoldImageCoeff": 13,
-  "isAboveTheFoldPriceCoeff": 33,
-  "isNearbyImageXAxisPriceCoeff": 5,
+  "backgroundIdImageCoeff": 4,
+  "bigFontCoeff": 14,
+  "bigImageCoeff": 9,
+  "extremeAspectCoeff": 3,
+  "hasDollarSignCoeff": 3,
+  "hasPriceInClassNameCoeff": 7,
+  "hasPriceInIDCoeff": 8,
+  "hasPriceInParentClassNameCoeff": -1,
+  "hasPriceInParentIDCoeff": -2,
+  "hasPriceishPatternCoeff": 4,
+  "isAboveTheFoldImageCoeff": 5,
+  "isAboveTheFoldPriceCoeff": -19,
   "isNearbyImageYAxisTitleCoeff": 5,
-  "largerFontSizeCoeff": 7,
-  "largerImageCoeff": 2
+  "isNearImageCoeff": 4
 }

src/extraction/fathom/index.js

@@ -32,8 +32,23 @@ const FEATURE_DEFAULTS = {
 const PRODUCT_FEATURES = {
   image: {
     ...FEATURE_DEFAULTS,
+    /**
+     * @return the URL of an image resource
+     */
     getValueFromElement(element) {
-      return element.src;
+      /**
+       * Given a CSS url() declaration 'url("http://foo")', return 'http://foo'.
+       */
+      function urlFromCssDeclaration(declaration) {
+        return declaration.slice(5, -2);
+      }
+
+      if (element.tagName === 'IMG') {
+        return element.src;
+      }
+      // The other thing the ruleset can return is an arbitrary element with
+      // a CSS background image.
+      return urlFromCssDeclaration(getComputedStyle(element)['background-image']);
     },
   },
   title: {