Skip to content
This repository has been archived by the owner on Dec 3, 2020. It is now read-only.

Default network.cookie.cookieBehavior setting in Beta 64 and Nightly 65 disables background extraction #183

Closed
biancadanforth opened this issue Oct 19, 2018 · 1 comment

Comments

@biancadanforth
Copy link
Collaborator

biancadanforth commented Oct 19, 2018

In Issue #72 , we implemented behavior changes in the extension based on various privacy contexts (#72 (comment)).

One of those changes was to disable background extraction (price polling) when certain cookie restrictions were in place. The current behavior is to disable background extraction for the following values of network.cookie.cookieBehavior:

  • 1: 'reject_third_party'
  • 2: 'reject_all'
  • 4: 'reject_trackers'

A patch just landed in Nightly to set this preference's default value to 4, which means if left as-is, the extension's background extraction and telemetry will be disabled by default in Firefox 64+.

Previously, groovecoder had expressed this requirement for enabling background extraction in this situation:

I think it would be okay to continue price-polling even with cookieBehavior set to 4 so long as there’s an extra opt-in interstitial in the experiment. Something like what I commented in #72 (comment)

@groovecoder , @chuckharmston : Are there any blocking changes needed here for the MVP? Post-MVP?

Engineering-wise, background updates shouldn't violate whatever cookie policy is in place. With groovecoder's help, I compared the Cookies header value between a product page in the content process and loaded for background extraction, and they were the same for a setting of 3.

@chuckharmston
Copy link

chuckharmston commented Oct 19, 2018

I don't think this blocks launch, but I would like to make sure this is released before any major marketing pushes past Test Pilot's regular social media and newsletter ones (e.g. if we do a snippet, CFR, or FOMO promo).

I'm going to create a milestone for issues I'd like to hit pre-launch and post-MVP, but wouldn't block launch if there's a pinch. This will go there.

biancadanforth added a commit that referenced this issue Oct 19, 2018
Also added the cookie pref from Issue #183, so background updates occur in Nightly.
@biancadanforth biancadanforth added the [ENG]: Triage Work the team needs to review to determine if it will be included as part of the next milestone. label Oct 22, 2018
biancadanforth added a commit that referenced this issue Oct 22, 2018
Also added the cookie pref from Issue #183, so background updates occur in Nightly.
biancadanforth added a commit that referenced this issue Oct 22, 2018
Also added the cookie pref from Issue #183, so background updates occur in Nightly.
@muccimoz muccimoz added reserve-November milestone and removed [ENG]: Triage Work the team needs to review to determine if it will be included as part of the next milestone. labels Oct 23, 2018
@muccimoz muccimoz added this to the November MVP milestone Oct 23, 2018
@muccimoz muccimoz removed this from the November MVP milestone Nov 8, 2018
@biancadanforth biancadanforth changed the title Default network.cookie.cookieBehavior setting in Nightly disables background extraction Default network.cookie.cookieBehavior setting in Beta 64 and Nightly 65 disables background extraction Nov 8, 2018
biancadanforth added a commit to biancadanforth/price-tracker that referenced this issue Nov 8, 2018
biancadanforth added a commit that referenced this issue Nov 8, 2018
Fix #258, Fix #183: Record extension event telemetry by default in all channels
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants