Skip to content
This repository has been archived by the owner on Dec 3, 2020. It is now read-only.

The eBay favicon is not displayed on the left side of the product's price when accessing the door hanger in Private Browsing Mode #243

Closed
SoftVision-CarmenFat opened this issue Nov 5, 2018 · 2 comments
Closed

The eBay favicon is not displayed on the left side of the product's price when accessing the door hanger in Private Browsing Mode #243

SoftVision-CarmenFat opened this issue Nov 5, 2018 · 2 comments
Assignees
@Osmose
Labels
[ENG]: Reserve Low-priority work related to a specific milestone. [QA]:Normal issue Label for QA to mark normal issues logged [QA]:Verified fixed Label for QA to mark verified fixed issues
Milestone
Post-Launch Devel...

Comments

@SoftVision-CarmenFat
Copy link

[Affected versions]:

  • Firefox Release v63.0 and up

[Affected Platforms]:

  • All Windows
  • All Linux
  • All Mac (except Nightly channel)

[Prerequisites]:

  • Have a Firefox profile with the latest version of the "Price Wise" add-on (8.0.1) downloaded from (download link).
  • A product from eBay was already added to the list.

[Steps to reproduce]:

  1. Open the browser with the profile from prerequisites.
  2. Press "Ctrl"+"Shift"+"P" keys in order to open a Private Window.
  3. Click the Price Wise toolbar button from the Private Window.
  4. Observe the favicon of the website.

[Expected result]:

  • The eBay favicon is displayed on the left side of the product's price.

[Actual result]:

  • The eBay favicon is not displayed.

[Notes]:

  • Here is a screen recording of the issue:

pbm
@SoftVision-CarmenFat SoftVision-CarmenFat added the [QA]:Normal issue Label for QA to mark normal issues logged label Nov 5, 2018
@muccimoz muccimoz added [ENG]: Triage Work the team needs to review to determine if it will be included as part of the next milestone. and removed [ENG]: Triage Work the team needs to review to determine if it will be included as part of the next milestone. labels Nov 5, 2018
@Osmose Osmose added this to the Post-Launch Development-1 milestone Nov 11, 2018
@biancadanforth biancadanforth removed this from the Post-Launch Development-1 milestone Nov 19, 2018
@biancadanforth biancadanforth added the [ENG]: Reserve Low-priority work related to a specific milestone. label Nov 19, 2018
@biancadanforth
Copy link
Collaborator

Moving this to reserve in favor of #274 .

@Osmose Osmose self-assigned this Nov 27, 2018
Osmose pushed a commit to Osmose/price-wise that referenced this issue Nov 28, 2018
Fix mozilla#243: Serve vendor favicons locally instead of remotely.
0cfc31c 
Tracking protection is blocking the eBay favicon from being loaded in private
browsing mode, but serving it locally instead of fetching it from the internet
avoids being blocked.
@Osmose Osmose closed this as completed in 4756acd Nov 28, 2018
Osmose added a commit that referenced this issue Nov 28, 2018
@Osmose
Merge pull request #287 from Osmose/private-icon
a0c327f 
Fix #243: Serve vendor favicons locally instead of remotely.
@muccimoz muccimoz added this to the Post-Launch Development-1 milestone Nov 28, 2018
@Softvision-RemusDranca
Copy link

I have verified this issue using the latest Price Wise version (16.0.0) custom build on 11/29/2018, and the issue is no longer reproducible. Tested on Windows 10x64, Mac 10.13 and Ubuntu 18.04 x64.

@Softvision-RemusDranca Softvision-RemusDranca added the [QA]:Verified fixed Label for QA to mark verified fixed issues label Nov 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Osmose Osmose

Labels
[ENG]: Reserve Low-priority work related to a specific milestone. [QA]:Normal issue Label for QA to mark normal issues logged [QA]:Verified fixed Label for QA to mark verified fixed issues
Projects
None yet
Milestone
Post-Launch Development-1
Development

No branches or pull requests
5 participants
@Osmose @biancadanforth @SoftVision-CarmenFat @Softvision-RemusDranca @muccimoz