This repository has been archived by the owner on Dec 3, 2020. It is now read-only.
Remove prototype sidebar #33
Assignees
Comments
biancadanforth
added a commit
that referenced
this issue
Jul 26, 2018
biancadanforth
added a commit
that referenced
this issue
Jul 27, 2018
Removed the sidebar panel, and added a pageAction panel, which opens/closes on pageAction click.
Added a 'priceComparison' object that, similar to the 'product' object, is passed from 'background.js' to the pageAction panel ('./src/popup/index.jsx') via the panel's URL as a query string. This 'priceComparison' object is currently pulled from a stub method, 'getPriceComparisonData', which currently just returns a static object literal. Ultimately this method would call an external API and return the data we need to display in the panel.
TODO: Add CSS and top left-most icon.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
We added a sidebar to help drive prototyping, but it's time to remove it and the related, non-reusable code that supports it. We should keep things like the pending-landing code for running automated tests that we'll eventually reuse.
The text was updated successfully, but these errors were encountered: