This repository has been archived by the owner on Dec 3, 2020. It is now read-only.
What should the extension do when there is not a single price on a product page? #86
Labels
[ENG]: Extraction
Issues related to product extraction, including Fathom
Comments
|
Thank you Sharon; you raise an important semantic and product question: This page and others, like the Etsy page in #88 and the Macy's page and Walmart page in #79 do not represent a single product but a class of products with an often implicit range of prices.
From a technical point of view, we don't know how to determine what the correct price is, since pages like these violate our extension's assumption that there is a single product on a product page. We also wouldn't know how to update the prices in the background in many cases, since the URLs for sites like Etsy (example) may not change to reflect that the user selected a particular variation. Edit: Going to rename this issue to be more reflective of the question it raises. Also related: #43 . |
biancadanforth
changed the title
biancadanforth
added a commit
that referenced
this issue
Sep 12, 2018
* Update how we pull the price string from extracted Fathom price elements to provide main and subunits (e.g. dollars and cents) if available. * Added price string cleaning methods to remove extra characters (like commas) that were causing price parsing to fail. * Handle case when price string parsing still fails after cleaning by checking in the background script that the price string is formatted correctly before rendering the browserAction popup. * This will guarantee we never see the “blank panel” reported in #79/#88. Price element innerText strings now supported as a result of these changes: * "$1327 /each" ([Home Depot example page](https://www.homedepot.com/p/KitchenAid-Classic-4-5-Qt-Tilt-Head-White-Stand-Mixer-K45SSWH/202546032)) * "$1,049.00" ([Amazon example page](https://www.amazon.com/Fujifilm-X-T2-Mirrorless-F2-8-4-0-Lens/dp/B01I3LNQ6M/ref=sr_1_2?ie=UTF8&qid=1535594119&sr=8-2&keywords=fuji+xt2+camera)) * "US $789.99" ([Ebay example page](https://www.ebay.com/itm/Dell-Inspiron-7570-15-6-Touch-Laptop-i7-8550U-1-8GHz-8GB-1TB-NVIDIA-940MX-W10/263827294291)) * "$4.99+" ([Etsy example page](https://www.etsy.com/listing/555504975/frankenstein-2-custom-stencil?ga_order=most_relevant&ga_search_type=all&ga_view_type=gallery&ga_search_query=&ref=sr_gallery-1-13)) Note: This does not handle the case where there is more than one price for the product page (e.g. if we see a range of prices such as "$19.92 - $38.00" or if the price changes based on size/color, etc.); that’s handled by Issue #86.
biancadanforth
added a commit
that referenced
this issue
Sep 12, 2018
* Update how we pull the price string from extracted Fathom price elements to provide main and subunits (e.g. dollars and cents) if available. * Add price string cleaning methods to remove extra characters (like commas) that were causing price parsing to fail. * Handle case when price string parsing still fails after cleaning by checking in the background script that the price string is formatted correctly before rendering the browserAction popup. * This will guarantee we never see the “blank panel” reported in #79 and #88. Price element innerText strings now supported as a result of these changes: * "$1327 /each" ([Home Depot example page](https://www.homedepot.com/p/KitchenAid-Classic-4-5-Qt-Tilt-Head-White-Stand-Mixer-K45SSWH/202546032)) * "$1,049.00" ([Amazon example page](https://www.amazon.com/Fujifilm-X-T2-Mirrorless-F2-8-4-0-Lens/dp/B01I3LNQ6M/ref=sr_1_2?ie=UTF8&qid=1535594119&sr=8-2&keywords=fuji+xt2+camera)) * "US $789.99" ([Ebay example page](https://www.ebay.com/itm/Dell-Inspiron-7570-15-6-Touch-Laptop-i7-8550U-1-8GHz-8GB-1TB-NVIDIA-940MX-W10/263827294291)) * "$4.99+" ([Etsy example page](https://www.etsy.com/listing/555504975/frankenstein-2-custom-stencil?ga_order=most_relevant&ga_search_type=all&ga_view_type=gallery&ga_search_query=&ref=sr_gallery-1-13)) Note: This does not handle the case where there is more than one price for the product page (e.g. if we see a range of prices such as "$19.92 - $38.00" or if the price changes based on size/color, etc.); that’s handled by Issue #86.
biancadanforth
added a commit
that referenced
this issue
Sep 18, 2018
* Update how we pull the price string from extracted Fathom price elements to provide main and subunits (e.g. dollars and cents) if available. * Add price string cleaning methods to remove extra characters (like commas) that were causing price parsing to fail. * Handle case when price string parsing still fails after cleaning by checking in the background script that the price string is formatted correctly before rendering the browserAction popup. * This will guarantee we never see the “blank panel” reported in #79 and #88. Price element innerText strings now supported as a result of these changes: * "$1327 /each" ([Home Depot example page](https://www.homedepot.com/p/KitchenAid-Classic-4-5-Qt-Tilt-Head-White-Stand-Mixer-K45SSWH/202546032)) * "$1,049.00" ([Amazon example page](https://www.amazon.com/Fujifilm-X-T2-Mirrorless-F2-8-4-0-Lens/dp/B01I3LNQ6M/ref=sr_1_2?ie=UTF8&qid=1535594119&sr=8-2&keywords=fuji+xt2+camera)) * "US $789.99" ([Ebay example page](https://www.ebay.com/itm/Dell-Inspiron-7570-15-6-Touch-Laptop-i7-8550U-1-8GHz-8GB-1TB-NVIDIA-940MX-W10/263827294291)) * "$4.99+" ([Etsy example page](https://www.etsy.com/listing/555504975/frankenstein-2-custom-stencil?ga_order=most_relevant&ga_search_type=all&ga_view_type=gallery&ga_search_query=&ref=sr_gallery-1-13)) Note: This does not handle the case where there is more than one price for the product page (e.g. if we see a range of prices such as "$19.92 - $38.00" or if the price changes based on size/color, etc.); that’s handled by Issue #86.
|
This is a super important conversation -- and why we need to be in Test Pilot. First, we can move this beyond the MVP and ship as-is. We'll get some helpful user feedback. We can backlog this one for post-MVP and think about it in multiple contexts. This one straddles not just a large body of work that would fit under "fathom improvement" but also general UI improvements. |
|
We likely can learn from other extensions like Honey how they handle some of these edge cases for guidance on how to handle.
…On Wed, Sep 19, 2018 at 2:06 PM, Javaun Moradi < ***@***.*** > wrote:
This is a super important conversation -- and why we need to be in Test
Pilot. First, we can move this beyond the MVP and ship as-is. We'll get
some helpful user feedback.
We can backlog this one for post-MVP and think about it in multiple
contexts. This one straddles not just a large body of work that would fit
under "fathom improvement" but also general UI improvements.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub (
#86 (comment)
) , or mute the thread (
https://github.com/notifications/unsubscribe-auth/AJQPSC3vjxWdJ44xxKIV8Csbm4ImYMI6ks5ucrHDgaJpZM4WT-he
).
|
biancadanforth
added a commit
that referenced
this issue
Sep 20, 2018
* Update how we pull the price string from extracted Fathom price elements to provide main and subunits (e.g. dollars and cents) if available. * Add price string cleaning methods to remove extra characters (like commas) that were causing price parsing to fail. * Handle case when price string parsing still fails after cleaning by checking in the background script that the price string is formatted correctly before rendering the browserAction popup. * This will guarantee we never see the “blank panel” reported in #79 and #88. Price element innerText strings now supported as a result of these changes: * "$1327 /each" ([Home Depot example page](https://www.homedepot.com/p/KitchenAid-Classic-4-5-Qt-Tilt-Head-White-Stand-Mixer-K45SSWH/202546032)) * "$1,049.00" ([Amazon example page](https://www.amazon.com/Fujifilm-X-T2-Mirrorless-F2-8-4-0-Lens/dp/B01I3LNQ6M/ref=sr_1_2?ie=UTF8&qid=1535594119&sr=8-2&keywords=fuji+xt2+camera)) * "US $789.99" ([Ebay example page](https://www.ebay.com/itm/Dell-Inspiron-7570-15-6-Touch-Laptop-i7-8550U-1-8GHz-8GB-1TB-NVIDIA-940MX-W10/263827294291)) * "$4.99+" ([Etsy example page](https://www.etsy.com/listing/555504975/frankenstein-2-custom-stencil?ga_order=most_relevant&ga_search_type=all&ga_view_type=gallery&ga_search_query=&ref=sr_gallery-1-13)) Note: This does not handle the case where there is more than one price for the product page (e.g. if we see a range of prices such as "$19.92 - $38.00" or if the price changes based on size/color, etc.); that’s handled by Issue #86.
Osmose
added
[ENG]: Extraction
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
I initially set an alert for the 400ml version of this watering can: https://www.amazon.com/dp/B06X6FSJNP/ref=sspa_dk_detail_0?pd_rd_i=B06WRQPNJ4&pf_rd_m=ATVPDKIKX0DER&pf_rd_p=a54d13fc-b8a1-4ce8-b285-d77489a09cf6&pf_rd_r=7MC0VQSVZZFDYAS9KBZ4&pd_rd_wg=PNtEh&pf_rd_s=desktop-dp-sims&pf_rd_t=40701&pd_rd_w=tKkis&pf_rd_i=desktop-dp-sims&pd_rd_r=586b96ae-ac7f-11e8-861c-cd06ea1130b1&th=1
I was able to create that 400ml watering can alert as expected. When I went to view the 900ml version of that watering can, the extension would not detect the page (900ml can is page being viewed; 400ml can is reflected in alert panel):
This instance raises a few questions:
The text was updated successfully, but these errors were encountered: