This repository has been archived by the owner on Dec 3, 2020. It is now read-only.
Fix #91: Update toolbar icon to final icon. #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I noticed that the about:addons icons weren't displaying, and found bug 1376518. To avoid the inconsistency, I added PNG versions of the icon to use for about:addons. |
biancadanforth
approved these changes
Sep 19, 2018
There was a problem hiding this comment.
R+ WC. This looks good! Good catch on the about:addons SVG bug.
The only thing else to do is to remove the old browserAction icon, tracking.svg from the img folder.
Also, I noticed another bug while reviewing your patch (not related to your patch), so I am going to file an issue for it:
- When visiting the Fake Product Page, I got a price alert when the price increased.
added 3 commits
September 19, 2018 15:16
Also removes the icon from the notification, as it doesn't scale well.
SVGs don't display consistently in about:addons; see bug 1376518.
Osmose
force-pushed
the
toolbar-icon
branch
from
da14dbb to
95b8c09
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removes the icon from the notification, as it doesn't scale well.