Skip to content
This repository has been archived by the owner on Dec 3, 2020. It is now read-only.

Fix #243: Serve vendor favicons locally instead of remotely. #287

Merged
merged 1 commit into from
Nov 28, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added src/img/favicons/amazon.ico
Binary file not shown.
Binary file added src/img/favicons/bestbuy.ico
Binary file not shown.
Binary file added src/img/favicons/ebay.ico
Binary file not shown.
Binary file added src/img/favicons/homedepot.ico
Binary file not shown.
Binary file added src/img/favicons/walmart.ico
Binary file not shown.
10 changes: 5 additions & 5 deletions src/state/vendors.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,27 +23,27 @@ const VENDORS = [
{
name: 'Amazon',
hostnames: ['amazon.com', 'www.amazon.com', 'smile.amazon.com'],
faviconUrl: 'https://www.amazon.com/favicon.ico',
faviconUrl: browser.runtime.getURL('/img/favicons/amazon.ico'),
},
{
name: 'Best Buy',
hostnames: ['bestbuy.com', 'www.bestbuy.com'],
faviconUrl: 'https://www.bestbuy.com/favicon.ico',
faviconUrl: browser.runtime.getURL('/img/favicons/bestbuy.ico'),
},
{
name: 'eBay',
hostnames: ['ebay.com', 'www.ebay.com'],
faviconUrl: 'https://www.ebay.com/favicon.ico',
faviconUrl: browser.runtime.getURL('/img/favicons/ebay.ico'),
},
{
name: 'The Home Depot',
hostnames: ['homedepot.com', 'www.homedepot.com'],
faviconUrl: 'https://www.homedepot.com/favicon.ico',
faviconUrl: browser.runtime.getURL('/img/favicons/homedepot.ico'),
},
{
name: 'Walmart',
hostnames: ['walmart.com', 'www.walmart.com'],
faviconUrl: 'https://www.walmart.com/favicon.ico',
faviconUrl: browser.runtime.getURL('/img/favicons/walmart.ico'),
},
{
name: 'mkelly Test',
Expand Down
1 change: 1 addition & 0 deletions webpack/common.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ module.exports = {
// Static files
{from: '**/*.svg'},
{from: '**/*.png'},
{from: '**/*.ico'},
{from: '**/*.html'},

// Experimental APIs, which are not bundled
Expand Down