Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #1074 Fixed error with yeild in ComputedPropertyName #1553

Merged
merged 2 commits into from
Aug 9, 2024
Merged

fix #1074 Fixed error with yeild in ComputedPropertyName #1553

merged 2 commits into from
Aug 9, 2024

Conversation

tuchida
Copy link
Contributor

@tuchida tuchida commented Aug 2, 2024

Closes #1074

Running the following code in non-interpreted mode will throw NullPointerException. ref. #1074 (comment)

function* g() {
  var obj = {
    get [yield]() { return 'get yield'; }
  };
}

Test262SuiteTest does not display the exception, but you can see it by uncommenting this line.

// enable line below to print out stacktraces of unexpected exceptions
// disabled for now because too many exceptions are throw
// Unexpected non-Rhino-Exception here, so print the exception so it stands out
// ex.printStackTrace();

There are many exceptions other than NullPointerException, so I will leave the comment as they are. For example, java.lang.RuntimeException: Failed to build a scope with the harness files. errors seems to be resolved by #1540.

@tuchida tuchida changed the title fix #1074 Fixed error with yeild in ComputedPropertyName #1550 fix #1074 Fixed error with yeild in ComputedPropertyName Aug 2, 2024
@@ -854,7 +851,6 @@ private Node transformObjectLiteral(ObjectLiteral node) {
}
}
object.putProp(Node.OBJECT_IDS_PROP, properties);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The properties are a mixture of String, Integer and Node, where Node is Computed Property Name.

@gbrail
Copy link
Collaborator

gbrail commented Aug 8, 2024

Good progress and thanks! Can you please re-base this on top of the latest to pick up the new test262 changes? Thanks!

@gbrail
Copy link
Collaborator

gbrail commented Aug 9, 2024

Thanks for fixing this -- looks good!

@gbrail gbrail merged commit 4a1e870 into mozilla:master Aug 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nullPointer while running test262 in non-interpreted mode
2 participants