Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Silenced all warnings #1576

Merged
merged 1 commit into from
Aug 24, 2024
Merged

Silenced all warnings #1576

merged 1 commit into from
Aug 24, 2024

Conversation

andreabergia
Copy link
Contributor

Simply silences all warnings printed out in a build from master:

  • two by marking them with @SuppressWarnings("deprecation"), because I don't think we can change the code without breaking anything:
  • one by adding the cast suggested by ErrorProne. It does not change the behavior, since that cast was already being inserted implicitly by the compiler.

@gbrail
Copy link
Collaborator

gbrail commented Aug 24, 2024

Thanks, looks good!

@gbrail gbrail merged commit bd4c086 into mozilla:master Aug 24, 2024
3 checks passed
@andreabergia andreabergia deleted the silence-all-warnings branch November 28, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andreabergia @gbrail