When dumping icode, include string constants #1693
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
Token.printICode
is set to true (generally only for debugging purposes), Rhino prints all the interpreter bytecode it generated. For theIcode_REG_STRxx
instructions Rhino will also print inline the string value, but it does not do it for the (far more common)Icode_REG_STR_Cxx
instructions.This tiny PR just extends the same behavior to the
Icode_REG_STR_Cxx
. Therfore, for this js code:it will now print this:
whereas the old version would have just printed something like:
There are no unit tests for all this stuff, but it's currently being used only for debugging purposes... so I didn't really think that it was worth creating a whole test suite from scratch for this change.