-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: rust coverage test meets compile error for missing debuginfo #1740
Merged
+67
−8
Merged
Changes from 5 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
30b616e
ignore file not found error
yihau b9fb161
Revert "ignore file not found error"
yihau 42eac8c
make gcno as optional files in rust compiler
yihau 639976b
fix redundant clone
yihau d505f65
add integration test, issues-1652
yihau adcec3a
make test more general
yihau 3e0a326
move env to job level
yihau 9bbf8b4
test coverage twice and print status
yihau 10b37a7
fix working directory
yihau File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -609,3 +609,32 @@ jobs: | |
${SCCACHE_PATH} --show-stats | ||
|
||
${SCCACHE_PATH} --show-stats | grep -e "Cache hits\s*[1-9]" | ||
|
||
issues-1652: | ||
runs-on: ubuntu-latest | ||
needs: build | ||
|
||
strategy: | ||
fail-fast: false | ||
matrix: | ||
version: [nightly-2023-02-08, nightly-2023-02-09] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is it necessary to hard-coded the date? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I found it's broken since the version |
||
steps: | ||
- uses: actions/download-artifact@v3 | ||
with: | ||
name: integration-tests | ||
path: /home/runner/.cargo/bin/ | ||
- name: Chmod for binary | ||
run: chmod +x ${SCCACHE_PATH} | ||
|
||
- name: Coverage test | ||
run: | | ||
rustup toolchain install ${{ matrix.version }} | ||
cargo new hello | ||
cd hello | ||
echo "serde = { version = \"1.0\", features = [\"derive\"] }" >> Cargo.toml | ||
cargo +${{ matrix.version }} test | ||
env: | ||
RUSTC_WRAPPER: /home/runner/.cargo/bin/sccache | ||
CARGO_INCREMENTAL: "0" | ||
RUSTFLAGS: "-Zprofile -Ccodegen-units=1 -Copt-level=0 -Clink-dead-code -Coverflow-checks=off -Zpanic_abort_tests -Cpanic=abort" | ||
RUSTDOCFLAGS: "-Cpanic=abort" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please rename the test for something more explicit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you have any prefer name? is
missing-debug-info
a good name?