Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(redis): add support for ttl, fix #1666 #2027

Merged
merged 4 commits into from
Jan 12, 2024

Conversation

sudhackar
Copy link
Contributor

Fixes #1666

Adds a ttl to opendal if SCCACHE_REDIS_TTL env var is set and not zero.

@sudhackar sudhackar changed the title Add support for SCCACHE_REDIS_TTL feat(redis): add support for ttl, fix #1666 Jan 11, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 11, 2024

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (11703e0) 31.02% compared to head (5ae8e54) 30.74%.

Files Patch % Lines
src/config.rs 41.17% 5 Missing and 5 partials ⚠️
src/cache/redis.rs 0.00% 3 Missing ⚠️
src/cache/cache.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2027      +/-   ##
==========================================
- Coverage   31.02%   30.74%   -0.29%     
==========================================
  Files          51       51              
  Lines       19617    19621       +4     
  Branches     9418     9411       -7     
==========================================
- Hits         6087     6032      -55     
- Misses       7874     7882       +8     
- Partials     5656     5707      +51     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, thanks!

docs/Configuration.md Outdated Show resolved Hide resolved
docs/Redis.md Outdated Show resolved Hide resolved
src/config.rs Outdated Show resolved Hide resolved
@sylvestre sylvestre merged commit 9d1696b into mozilla:main Jan 12, 2024
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow Setting Redis Key Experation
4 participants