Fix #2694 Link to the graduation reports in the blog. #2875
Conversation
| @@ -123,7 +123,7 @@ export default class LocalizedHtml extends Localized { | |||
| } | |||
| ); | |||
| } | |||
| throw new Error('ftl string did not have as many anchors as the jsx'); | |||
| throw new Error(`ftl string "${this.props.id}" did not have as many anchors as the jsx`); | |||
There was a problem hiding this comment.
This is unrelated, but it helped me debug something while working on this branch, might as well get it into master.
|
Still need to:
|
And fix conflicts # Conflicts: # frontend/test-setup.js # gulpfile.babel.js # package.json
Codecov Report
@@ Coverage Diff @@
## master #2875 +/- ##
==========================================
+ Coverage 94.78% 94.85% +0.06%
==========================================
Files 88 90 +2
Lines 2243 2254 +11
==========================================
+ Hits 2126 2138 +12
+ Misses 117 116 -1
Continue to review full report at Codecov.
|
|
The test failures seem to be a temporary problem with circle. |
fzzzy
changed the title
|
The temporary circle problem obscured the lint errors. |
locales/en-US/app.ftl
Outdated
| [[graduated]] | ||
| graduationReportButton=Graduation Report | ||
| graduationNoticeTitle=This experiment has ended | ||
| graduationNoticeReportNotReady=We are working on a full report. Check back soon for the details. |
There was a problem hiding this comment.
Why are we duplicating two existing strings? Are those used anywhere?
experimentGradReportPendingTitle = This experiment has ended
experimentGradReportPendingCopy = We are working on a full report. Check back soon for the details.
There was a problem hiding this comment.
Thank you for pointing this out! I searched for "graduation" but there were no hits, and "grad" hit a bunch of other things that were not related. I will re-use the existing strings.
|
|
||
|
|
||
|
|
||
| .graduated-notice { |
There was a problem hiding this comment.
nit, extra new lines
| @@ -0,0 +1,19 @@ | |||
|
|
|||
|
|
|||
| import React from 'react'; | |||
There was a problem hiding this comment.
nit, new lines at beginning of file
|
|
||
| import { storiesOf } from '@storybook/react'; | ||
|
|
||
| import GraduatedNotice from './index'; |
There was a problem hiding this comment.
inconsistent spacing of new lines
|
Since this has a string change, this shouldn't land until the new sprint starts. |
# Conflicts: # frontend/test-setup.js # gulpfile.babel.js # package.json
|
New sprint is go, and we updated staging. Merging! |
No description provided.