Skip to content

Commit

Permalink
rust: arch/um: Disable FP/SIMD instruction to match x86
Browse files Browse the repository at this point in the history
[ Upstream commit 8849818679478933dd1d9718741f4daa3f4e8b86 ]

The kernel disables all SSE and similar FP/SIMD instructions on
x86-based architectures (partly because we shouldn't be using floats in
the kernel, and partly to avoid the need for stack alignment, see:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=53383 )

UML does not do the same thing, which isn't in itself a problem, but
does add to the list of differences between UML and "normal" x86 builds.

In addition, there was a crash bug with LLVM < 15 / rustc < 1.65 when
building with SSE, so disabling it fixes rust builds with earlier
compiler versions, see:
Rust-for-Linux/linux#881

Signed-off-by: David Gow <[email protected]>
Reviewed-by: Sergio González Collado <[email protected]>
Signed-off-by: Richard Weinberger <[email protected]>
Signed-off-by: Sasha Levin <[email protected]>
  • Loading branch information
sulix authored and mozzaru committed Aug 11, 2023
1 parent 7dbeaa1 commit 14d19b8
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions arch/x86/Makefile.um
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
core-y += arch/x86/crypto/

#
# Disable SSE and other FP/SIMD instructions to match normal x86
#
KBUILD_CFLAGS += -mno-sse -mno-mmx -mno-sse2 -mno-3dnow -mno-avx
KBUILD_RUSTFLAGS += -Ctarget-feature=-sse,-sse2,-sse3,-ssse3,-sse4.1,-sse4.2,-avx,-avx2

ifeq ($(CONFIG_X86_32),y)
START := 0x8048000

Expand Down

0 comments on commit 14d19b8

Please sign in to comment.