Small improvements for better use #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: |
ianhi
requested changes
Jan 12, 2024
There was a problem hiding this comment.
Hi @Xraydylan thanks for this PR! This is going to be a great change, to my surprise it seems that most people use this library with only one class.
I've requested some coding changes below but looking good to start
|
the docs build is not your fault. I have an outdated config file that readthedocs finally stopped supporting. I'll fix that in a separate PR |
for more information, see https://pre-commit.ci
ianhi
merged commit 31a6504
into
mpl-extensions:pre-commit-ci-update-config
0 of 2 checks passed
|
Thank you for the contribution @Xraydylan ! You are actually the first contributor outside of me for this repo :) I really appreciate you taking the time to do this work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
classesan optional argument with the default class being "1"Added:
disable_legendargument to optionally not display classes in legendclear_positions()function to remove all points from a class (or all classes) with external call