Respect $dontVersionFields when versioning attributes #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nonoesp
reviewed
Sep 2, 2021
| * | ||
| * @return array | ||
| */ | ||
| public function arrayDiffAssocRecursive($array1, $array2) |
There was a problem hiding this comment.
Hey @jez500 - have you tested this for performance changes? Is this slower, the same, faster?
Also, is this adding recursivity, which this didn't have before?
There was a problem hiding this comment.
Hi @nonoesp
This will certainly be slower than the native php functions, but it is also doing more and doesn't cause a fatal error if a property is not a string (eg json fields). That said I have noticed no notable difference in performance with my testing.
Recursively is likely unavoidable with nested arrays, but will only kick in if there are actually nested arrays.
|
Thanks for the pull request! @jez500 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This both respects dontVersionFields and provides the ability to override what fields are getting versioned