vo_gpu_next: add chroma location to shader parameters #15239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasper93
force-pushed
the
chroma_loc
branch
2 times, most recently
from
24dd9fd to
a32552a
Compare
|
Download the artifacts for this pull request: |
|
I can confirm it works, tested with both left and centre chroma 👍 |
|
@natural-harmonia-gropius: Are you interested in something like that? Would current mapping work for you? Any suggestions? |
Yeah, this makes things much easier. I did some quick test, and it works well. 😀 |
|
Seems to work fine and do the job. Fill feature request if needed more properties or anything. |
Artoriuz
added a commit
to Artoriuz/glsl-joint-bilateral
that referenced
this pull request
Nov 2, 2024
This became possible after mpv-player/mpv#15239
Artoriuz
added a commit
to Artoriuz/glsl-chroma-from-luma-prediction
that referenced
this pull request
Nov 2, 2024
This became possible after mpv-player/mpv#15239
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.