Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix daly can init problems #139

Merged
merged 20 commits into from
Jan 2, 2025
Merged

Conversation

transistorgit
Copy link
Contributor

Hi Manuel,

your latest can cleanup introduced a problem that the daly can bms was not found or found only after 10 or so tries.

  • I moved the jk bms stuff into an "if" clause, as there is no data from daly available until the first request
  • I wait for the can_bus instance comming up by syncing with the thread. There were problems , as your new can init seems a bit slower

best regards
Bernd

@transistorgit
Copy link
Contributor Author

hi, as I'm still waiting for the new bms, I've made a daly can simulator. So I was able to implement the can-parallel stuff. It can handle multiple dalys on multiple can busses. and, we can test it without hardware. this may be the first step to pipeline integration steps 🙂
(btw: chat gpt wrote 98% of the simulator)
image
the 72% SOC bms is my physical device, the others are simulated

the cell voltage id hack makes the code very ugly. I propose to change the message cache into a time based id. this is how me make in in professional projects also. the cache key can be a tuple of can ID and timestamp. Then we can make the appplication code much cleaner

@mr-manuel
Copy link
Owner

Very nice! Could you please move the folder test outside of dbus-serialbattery? Else it's shipped with the driver on release and this is only needed for development.

@mr-manuel mr-manuel merged commit fa62314 into mr-manuel:master Jan 2, 2025
2 checks passed
@transistorgit
Copy link
Contributor Author

Hi,

I have received my 2 new Daly BMS's today and all the tests have gone well. I was able to connect 3 devices to one can bus or also on 2 can busses. Mixing serial and can devices doesn't work, only can is detected then. I'haven't investigated that, as this is possibly not needed.

Daly has releases a new bms series with internal 1A active balancer. These are blue now, not red. Also the app looks different, and you have to use a new PC configuration software (for changing the device address). They even have a new branding called "100balance"... very confusing for new users.

Probably you should note that on the documentation page.

image

image

@transistorgit
Copy link
Contributor Author

image

@mr-manuel
Copy link
Owner

Could you please post a screenshot and instructions on how to change the device address in the new software?

@transistorgit
Copy link
Contributor Author

  • Download new Software from here: https://www.100balancebms.com/en/download.asp. Choose "PC Host Programm for BMS"
  • Unpack it and start the JHB_serialport.exe. Windows may prevent this, override it.
  • Now the screen looks like this main
  • open the connection by choosing the right connection. I tried to use my Peak CAN USB dongle, but that don't work with this version (you can use the "older" daly "BMSTool-V1.14.23" software, that worked for me also, but is a bit more complicated. So if you don't have a proper CAN adapter for your PC, use a RS485 adapter and choose it from the serial port selection. Keep the baud rate at 9600 port dialog
  • Now you should see live values from your battery
  • Select "Engineering" from the left menu. There you can find the board address setting at top right engineering_set_board_no
  • Input your desired address and click "set". A green tick should appear. Thats all. engineering_set_board_no_success
  • Go back to the Main screen. Select your board number from the address selection at the top and you should see the live values again main_board_2
  • you can close the program now

@mr-manuel
Copy link
Owner

Nice, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants