Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

read production date and append to hardware version #5

Merged
merged 1 commit into from
May 5, 2023
Merged

read production date and append to hardware version #5

merged 1 commit into from
May 5, 2023

Conversation

transistorgit
Copy link
Contributor

this adds the battery production date to the hardware version string. maybe somebody can make use of it to distinguish multiply dalys

@mr-manuel
Copy link
Owner

I added two fields that could be populated, which are displayed in the GUI under "Device" page:

self._dbusservice.add_path(
"/Serial", self.battery.unique_identifier, writeable=True
)
self._dbusservice.add_path(
"/DeviceName", self.battery.production, writeable=True
)

Could you use them instead of adding it to self.hardware_version?

@mr-manuel mr-manuel merged commit 61571be into mr-manuel:jkbms_ble May 5, 2023
@mr-manuel
Copy link
Owner

I made some changes, see 6c4c545

@transistorgit transistorgit deleted the date_in_hw-version branch May 26, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants