Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "setOpened" private, let gixsql assume full ownership of the cursor state #115

Closed
mridoni opened this issue Aug 25, 2022 · 1 comment

Comments

@mridoni
Copy link
Owner

mridoni commented Aug 25, 2022

It basically depends on who (the driver or the "main" library) has ownership of the cursor's state. I guess the main library should have and set it appropriately depending on the return code from cursor_open/close_cursor. At that point setOpened can be made private in Cursor and removed from the "interface" in ICursor, since the drivers will no longer be using it.

Originally posted by @mridoni in #110 (comment)

mridoni added a commit that referenced this issue Nov 19, 2022
@mridoni
Copy link
Owner Author

mridoni commented Nov 19, 2022

046dfa9 should fix this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant