Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redhat: use variable galera_enable_mariadb_repo #117

Merged
merged 2 commits into from
Mar 15, 2022

Conversation

bufanda
Copy link
Contributor

@bufanda bufanda commented Mar 14, 2022

…epo use

Description

The variable galera_enable_mariadb_repo only omits configuration for mariadb repo in Debian. In environments with
limited access to the Internet and using RedHat Satellite to serve reopsitories this behaviour should also be available for RedHat configuration.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • I have run the pre-merge tests locally and they pass.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@elcomtik
Copy link
Collaborator

What version of mariaDB is available through RedHat Satellite? This role is tested only against 10.6

@bufanda
Copy link
Contributor Author

bufanda commented Mar 14, 2022

What version of mariaDB is available through RedHat Satellite? This role is tested only against 10.6

Satellite is like a repository mirror for systems without access to the internet with lifecycle management, so it is possible to serve the official mariadb repos but not with a direct link to the Internet. in RHEL8 the default Version is 10.2 or via AppStream 10.5. But we also use 10.6 as we serve the mariadb repos to our server. That said, we also use the role with 10.5 without issues. It's just the public repos we don't use and to allow us to use the internal repos this change we'd like to be upstream so we don't have to modify every time we update. It's more a convenience thing :)

@elcomtik
Copy link
Collaborator

Seems reasonable, I will aprove it for running tests

@elcomtik
Copy link
Collaborator

Please fix training whitespace lint error

@bufanda
Copy link
Contributor Author

bufanda commented Mar 15, 2022

fixed.

@elcomtik
Copy link
Collaborator

CentOS 8 test are broken, so LGTM.

@elcomtik elcomtik changed the title redhat: use variable galera_enable_mariadb_repo to disallow mariadb r… redhat: use variable galera_enable_mariadb_repo Mar 15, 2022
@elcomtik elcomtik merged commit 8a4c21a into mrlesmithjr:master Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants