fix: Fix mapping of itf and add new itf-14 type in iOS #3252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Awesome!! Nice high quality PR, thanks for the fix and thanks for the explanation. LGTM! ❤️ |
isaaccolson
pushed a commit
to isaaccolson/deliveries-mobile
that referenced
this pull request
Oct 30, 2024
* fix links * map itf to interleaved2of5 and add new itf-14 type for iOS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
I can't scan interleaved2of5 (ITF) barcodes in iOS.
Currently the CodeType
itfis mapped:Barcode.FORMAT_ITF, which is the "barcode format constant for ITF (Interleaved Two-of-Five)"AVMetadataObject.ObjectType.itf14, which is "a constant that identifies the ITF14 symbology"ITF-14 is a variant of ITF with a fixed length of 14 characters. The problem is that the iOS AVMetadataObject.ObjectType.interleaved2of5 type is not mapped at all and therefore interleaved2of5 barcodes with a different length than 14 characters cannot be scanned in iOS.
Changes
Added and changed the mapping for iOS:
Updated documentation about code types.
If you add now
itf-14unconditionally (i.e. don't exclude it for android) to thecodeTypesarray of the CodeScanner, in android it will (expectedly) throw the error "The given value for codeType could not be parsed! (Received: itf-14)".Tested on
Related issues