Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always update the url bar #19

Open
wants to merge 2 commits into
base: gh-pages
Choose a base branch
from
Open

Conversation

mlsteele
Copy link

Update the url on every change to the tree. This way you can just share the url immediately instead of having to open 'Options' and click 'Link'. I found this more convenient when collaborating as well as saving trees for later use.
I had to switch to using location.hash instead of location.search so that the browser doesn't reload.

Cheers,

  • Another Miles S.

querystring changes would reload the page.
@mshang
Copy link
Owner

mshang commented Feb 6, 2015

In principle, I agree with this change, however I think it would be too noisy to always have it on because

  1. the URL is messy
  2. users would have trouble understanding that they could just copy-paste the base.
    How about we replace the button with a toggle that defaults to off. When it's on, the address bar will have the full link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants