Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Huawei Maimang 5 / Nova (Plus) / G9 (Plus) #49

Merged
merged 2 commits into from
Jul 8, 2023

Conversation

bzy-080408
Copy link

support devices:
Huawei CAN-AL00
Huawei CAN-L01
Huawei CAN-L02
Huawei CAN-L03
Huawei CAN-TL00
Huawei MLA-AL00
Huawei MLA-L01
Huawei MLA-L02
Huawei MLA-L03
Huawei MLA-TL00

@bzy-080408
Copy link
Author

IMG_20230610_203246.jpg

@bzy-080408
Copy link
Author

sorry I forget it ...

@z3ntu
Copy link

z3ntu commented Jul 1, 2023

What are these tens of random model numbers? Are these actual phones? I doubt Huawei sells something branded as e.g. "Huawei MLA-L01"

@bzy-080408
Copy link
Author

What are these tens of random model numbers? Are these actual phones? I doubt Huawei sells something branded as e.g. "Huawei MLA-L01"

Huawei has two ways to name devices, one is the code name(e.g. Huawei Nova Plus;Huawei Maimang5) and the other is the model (e.g. MLA-AL00;CAN-L01)

@z3ntu
Copy link

z3ntu commented Jul 2, 2023

@bzy-080408 Then please add proper names also to both README and the dts files.

@bzy-080408
Copy link
Author

but one model of huawei device have more than two board-id and need more than two device-tree ,so how to name the device tree

@bzy-080408
Copy link
Author

and the system showed the model name

@bzy-080408 bzy-080408 requested a review from z3ntu July 7, 2023 01:40
@z3ntu z3ntu changed the title add huawei sdm625 devices support Add Huawei Maimang 5 / Nova (Plus) / G9 (Plus) Jul 7, 2023
dts/msm8953-huawei-milan.dts Outdated Show resolved Hide resolved
@z3ntu z3ntu requested review from ultra-azu and alikates July 7, 2023 12:18
@alikates
Copy link
Member

alikates commented Jul 7, 2023

Looks good to me, but please squash all commits into one.

Copy link

@z3ntu z3ntu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@z3ntu z3ntu merged commit cbf97d9 into msm8953-mainline:main Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants