Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Redmi 6 Pro (xiaomi-sakura) #51

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

barni2000
Copy link
Member

@barni2000 barni2000 commented Jun 23, 2023

It works fine for me I can go in the bootloader menu and i can use MI A2 Lite variant of PMOS also.

@barni2000 barni2000 marked this pull request as ready for review June 23, 2023 22:33
@barni2000 barni2000 force-pushed the sakura branch 2 times, most recently from e9e10b6 to 06fdbd4 Compare June 26, 2023 16:41
README.md Show resolved Hide resolved
Copy link

@z3ntu z3ntu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@z3ntu z3ntu requested a review from alikates July 1, 2023 14:38
@alikates
Copy link
Member

alikates commented Jul 2, 2023

Wont't it match first with daisy and not use this device entry? Both models share the same board id and same bootloader string.
Looks like we cannot differenciate between daisy and sakura so isn't this redundant with daisys entry?

@barni2000
Copy link
Member Author

Wont't it match first with daisy and not use this device entry? Both models share the same board id and same bootloader string. Looks like we cannot differenciate between daisy and sakura so isn't this redundant with daisys entry?

daisy has different board id qcom,board-id= <0x1000b 0x09>, sakura's board id same with mido and tissot qcom,board-id = <0x1000b 0> that cause this issue msm8953-mainline/linux#82.
It always match for mido first because mido hasn't got lk2nd,match-bootloader entry.

@alikates
Copy link
Member

Okay, LGTM

@alikates alikates merged commit 54174be into msm8953-mainline:main Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants