Daisy touchscreen compatible #57
Conversation
In the case a device has variants with specific touchscreen coupled with specific panel, it's useful to be able to declare both touchscreens with status "disabled" in Linux DTS, and have lk2nd NOP this status for the one associated with detected panel. Co-authored-by: Niklas Henrik Tonnätt <[email protected]> Co-authored-by: Nils Tonnaett <[email protected]>
Use the touchscreen-compatible support to associate the Goodix GT917D touchscreen with panels Ilitek ili7807-fhdplus, and Tianma otm1911-fhdplus and Focaltech ft5406 with panel Himax hx8399c-fhdplus. Co-authored-by: Niklas Henrik Tonnätt <[email protected]>
|
Is this strictly needed? When enabling all touchscreen drivers, all but one will probe so there won't be any issues. I guess this might be a cleaner solution that saves us from having probe error messages on boot. Also, are we sure that a panel model has always the same touchscreen controller? |
|
Btw, don't we need to set the status to 'okay' instead of NOPing the property? |
Enabling all touchscreen drivers in linux won’t work because the probe failing driver will claim the pins the other driver wants to use.
Sure, we don’t know if the panel touchscreen pairing is always this way but looking at this it very much seems this way. |
|
@ungeskriptet Since you added the otm1911-fhdplus panel and mentioned the use of the gt917d in the postmarketOS mainline channel. Do you have indeed this panel with the Goodix GT917D on your daisy? |
|
@apolemus Yes it has gt917d and otm1911-fhdplus. I don't have daisy though, I helped a friend add support for it. |
When I created the draft PR, I only copied the source from msm8916. As it works with this change, I assumed NOPing just resets 'status' to the default value. This confirms my assumptions. NULL and 'okay' both return true. I think this is ready to be merged. |
|
I also just add the touchscreen-compatible properties for the sakura. They seem to have the same display/touchscreen combinations. |
Use the touchscreen-compatible support to associate the Goodix GT917D touchscreen with panels Ilitek ili7807-fhdplus, and Tianma otm1911-fhdplus and Focaltech ft5406 with panel Himax hx8399c-fhdplus. Co-authored-by: Niklas Henrik Tonnätt <[email protected]>
|
Could we merge this? |
|
mido can be fixed in this way too. |
Mostly copied from msm8916-mainline#217, but for msm8953 and Xiaomi Daisy.